Skip to content

Updates AGENTS.md and styleguide#79

Merged
divyashreepathihalli merged 2 commits intomainfrom
agents-update
Mar 9, 2026
Merged

Updates AGENTS.md and styleguide#79
divyashreepathihalli merged 2 commits intomainfrom
agents-update

Conversation

@JyotinderSingh
Copy link
Collaborator

@JyotinderSingh JyotinderSingh commented Mar 9, 2026 •
edited
Loading

Updates docs for AI code + review regarding CLI design.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Mar 9, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the documentation for the AI code and review system. The primary goal is to accurately reflect recent architectural changes in the CLI's state management, module organization, and key abstractions, ensuring that the documentation remains current and provides clear guidance on the system's structure and behavior.

Highlights

  • Documentation Updates for CLI Structure: The AGENTS.md file has been updated to reflect changes in the CLI's directory structure, specifically introducing cli/options.py and detailing the state module within cli/infra.
  • Refined Module Responsibilities: The 'Key Modules' table in AGENTS.md was updated to include the new cli/infra/state.py and cli/options.py modules, along with a more detailed description for JobContext.
  • New Abstraction: StackState: A new StackState abstraction has been documented in the 'Key Abstractions' section, centralizing Pulumi state management.
  • Enhanced CLI State Management Explanation: The 'CLI State Management' section was significantly revised to explain the centralized state module (cli/infra/state.py), safety invariants, and cluster-scoped resource naming conventions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • AGENTS.md
    • Updated the directory structure to include cli/options.py and clarify the role of the state module within cli/infra.
    • Modified the description for constants.py to mention get_default_cluster_name().
    • Revised the 'Key Modules' table to update the responsibility of backend/execution.py and add entries for cli/infra/state.py and cli/options.py.
    • Updated the description of JobContext in 'Key Abstractions' to include cluster_name.
    • Added StackState to the 'Key Abstractions' section.
    • Completely re-wrote the 'CLI State Management' section to detail the centralized state module, safety invariants, and cluster-scoped resource naming patterns.
Ignored Files
  • Ignored by pattern: .gemini/** (1)
    • .gemini/styleguide.md
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@JyotinderSingh JyotinderSingh requested a review from jeffcarp March 9, 2026 12:24
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 9, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the AGENTS.md documentation to reflect a significant refactoring of the CLI's state management and resource naming strategy. The changes introduce a centralized state module, define safety invariants, and document cluster-scoped resource naming. My review focuses on the clarity and consistency of this new documentation. I have one suggestion to improve the clarity of a table describing resource naming.

Note: Security Review has been skipped due to the limited scope of the PR.

@JyotinderSingh @gemini-code-assist
Update AGENTS.md
43fd1fa 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@divyashreepathihalli divyashreepathihalli merged commit 05c1811 into main Mar 9, 2026
4 checks passed
@JyotinderSingh JyotinderSingh deleted the agents-update branch March 9, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divyashreepathihalli divyashreepathihalli divyashreepathihalli approved these changes

@jeffcarp jeffcarp Awaiting requested review from jeffcarp

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JyotinderSingh @divyashreepathihalli